Reset "can stand on top" flag and map after disconnection in FiveM #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lication Some natives weren't checking if the entity was valid (not nullptr).
gottfriedleibniz
approved these changes
Feb 15, 2024
github-actions
bot
added
the
triage
Disquse
removed
the
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The goal of this PR is to fix an oversight where the "can stand on top" flag (
g_overrideCanPedStandOnVehicle) and the vehicle map (g_canPedStandOnVehicles) weren't reset after disconnection from a server. Also, tweak some natives to usegetAndCheckVehicleto avoid code duplication.How is this PR achieving the goal
This PR achieves the goal by resetting the flag and map during
OnKillNetworkDone. Also, it tweaks the relevant code to use thegetAndCheckVehiclehelper.This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 1604, 2060, 2189, 2372, 2545, 2612, 2699, 2802, 2944, 3095
Platforms: Windows
Checklist
Fixes issues